Fix sigv4-s3express position in auth_scheme_options
#3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new doc preview is ready to view. |
jdisanti
reviewed
Mar 19, 2024
aws/sdk-codegen/src/main/kotlin/software/amazon/smithy/rustsdk/SigV4AuthDecorator.kt
Outdated
Show resolved
Hide resolved
|
A new doc preview is ready to view. |
|
A new doc preview is ready to view. |
Velfi
approved these changes
Mar 20, 2024
|
A new doc preview is ready to view. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rcoh
approved these changes
Mar 20, 2024
ysaito1001
deleted the
ysaito/fix-s3-express-position-in-auth-scheme-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes an S3-related bug introduced when s3 Express was added
Description
This PR fixes a bug where s3 Express auth flow was incorrectly used when no auth schemes were available for an endpoint. This use case was observed in test settings and manifested itself as a confusing behavior.
To address this issue, the fix ensures that an auth scheme for S3 express will be registered after that for sigv4 has been registered.
Testing
Added an integration test
s3_express_auth_flow_should_not_be_reached_with_no_auth_schemesChecklist
CHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.