Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix const names in codegen #3639

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented May 10, 2024

This renames stuff in codegen based on IntelliJ lints.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi Velfi requested review from a team as code owners May 10, 2024 19:42
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could use an automated linter/formatter that would keep these things from piling up? A quick search didn't turn up anything as authoritative as rustfmt, but there do seem to be some options out there. Beyond the scope of this PR, but might be a nice to have commit hook or something.

@drganjoo
Copy link
Contributor

This looks nice - thank you!

Should we also change PropertyKey to PROPERTY_KEY on line #45 of codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/rustlang/CargoDependency.kt?

        private const val PropertyKey = "rustdep"

@Velfi Velfi enabled auto-merge May 14, 2024 14:42
@Velfi
Copy link
Contributor Author

Velfi commented May 14, 2024

I wonder if we could use an automated linter/formatter that would keep these things from piling up?

Probably? These lints come from IntelliJ. We already have ktlint set up, maybe we just need to bring the configs of IntelliJ and ktlint in sync.

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi disabled auto-merge May 15, 2024 14:09
@aws-sdk-rust-ci aws-sdk-rust-ci merged commit 1ccf22d into main May 15, 2024
44 checks passed
@aws-sdk-rust-ci aws-sdk-rust-ci deleted the zhessler-fix-const-names-in-codegen branch May 15, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants