-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix const names in codegen #3639
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could use an automated linter/formatter that would keep these things from piling up? A quick search didn't turn up anything as authoritative as rustfmt
, but there do seem to be some options out there. Beyond the scope of this PR, but might be a nice to have commit hook or something.
This looks nice - thank you! Should we also change
|
Probably? These lints come from IntelliJ. We already have |
A new generated diff is ready to view.
A new doc preview is ready to view. |
This renames stuff in codegen based on IntelliJ lints.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.