Upgrade to Smithy 1.37.0 #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2023
trivikr
approved these changes
Sep 1, 2023
milesziemer
approved these changes
Sep 1, 2023
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 2, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For each of the generic auth (`@httpApiKeyAuth`, `@httpBearerAuth`, and `@aws.auth#sigv4`), make the identity providers and signers the same and available on all platforms. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 2, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For each of the generic auth (`@httpApiKeyAuth`, `@httpBearerAuth`, and `@aws.auth#sigv4`), make the identity providers and signers the same and available on all platforms. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 2, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For each of the generic auth (`@httpApiKeyAuth`, `@httpBearerAuth`, and `@aws.auth#sigv4`), make the identity providers and signers the same and available on all platforms. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 5, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 5, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 5, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. Also, update default identity providers to return `undefined` rather than a provider that throws an error. This is to allow for selection among multiple auth schemes without throwing errors. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 5, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`. feat(temp): temp
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 5, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 5, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
to syall/smithy-typescript
that referenced
this pull request
Sep 6, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (smithy-lang#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
syall
pushed a commit
that referenced
this pull request
Sep 6, 2023
…uthScheme` codegen After upgrading to Smithy 1.37.0 (#906), upgrade to `getEffectiveAuthSchemes` using `NO_AUTH_AWARE` and remove redundant code. For `HttpAuthOption`, allow any auth scheme to generate the corresponding `HttpAuthOption` function regardless of registering it in codegen. For `HttpAuthScheme`, reduce code duplication by looking at "inherited" `LanguageTarget` platforms (e.g. `REACT_NATIVE` inherits from `BROWSER`). `httpAuthSchemes` is only written in a `runtimeConfig` if the `IdentityProvider` and `Signer` are different between platforms, or if the registered `HttpAuthScheme`s are different. `httpAuthSchemes` is always written for `SHARED` as a default. For the `httpAuthSchemes` property on the client config interface, update it to `HttpAuthScheme[]` rather than `IdentityProviderConfiguration`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Upgrade to Smithy 1.37.0.
If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.