New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not handle data urls (inlined images) #1

Open

rally25rs opened this issue Mar 11, 2019 · 0 comments · May be fixed by #2

rally25rs commented Mar 11, 2019

Data urls get "sanitized" and have their quotes removed, which makes them invalid. For example

url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" fill="#fff" viewBox="0 0 8 8"></svg>');

Becomes

url(data:image/svg+xml;utf8,<svg xmlns=http://www.w3.org/2000/svg fill=#fff viewBox=0 0 8 8></svg>);

which causes 2 errors;

In Chrome at least (and probably other browsers) data URLs must be surrounded by quotes.
The quotes inside the SVG attributes are removed, which causes the SVG XML to be invalid to most parsers.

The text was updated successfully, but these errors were encountered:

rally25rs linked a pull request

that will close this issue

Do not manipulate data urls #2

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment