Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enums exported in camelCase #11

Closed
Fadelis opened this issue Jul 29, 2020 · 1 comment
Closed

Enums exported in camelCase #11

Fadelis opened this issue Jul 29, 2020 · 1 comment

Comments

@Fadelis
Copy link
Contributor

Fadelis commented Jul 29, 2020

Enums are exported in camelCase instead of UPPER_CASE. Not sure if that's intentional or not?
@smnbbrv
Copy link
Owner

smnbbrv commented Jul 29, 2020

Hi, this was intentional in the really beginning but now after all I think this should be changed to preserve the original naming in proto file. I'm working now on a complex release and probably include this breaking change there as well

@smnbbrv smnbbrv closed this as completed in cea22a0 Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fadelis @smnbbrv