Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client receives all the messages at once when using server-side streaming? #60

Closed
sfariv opened this issue Jun 10, 2021 · 5 comments
Closed

Comments

@sfariv
Copy link

sfariv commented Jun 10, 2021

Hi, I was wondering if that's still a expected behavior I am seeing?
client receives all the messages at once when using server-side streaming

I noticed this feature was a WAI back in 2019
https://grpc.io/blog/state-of-grpc-web/#f20

I was wondering if this is still not supported?

@kenyerman
Copy link

kenyerman commented Jun 10, 2021

It works for me, the client receives the messages separately, when pushed from the server. (Not on connection close)
I'm using grpc-web-client and Grpc.AspNetCore.Web for server side (learned from this tutorial).

Tested on:

  • Chrome v91
  • Firefox v88
  • Chrome iOS v91
  • Safari iOS v14

@smnbbrv
Copy link
Owner

smnbbrv commented Jun 11, 2021

This all depends on what client implementation you are using. If this issue persists try to contact the client library maintainers

@sfariv
Copy link
Author

sfariv commented Jun 12, 2021

Thanks for the answers,

I am not sure what you mean by client implementation? could you elaborate more? I am following your example @smnbbrv and it's still not working for me. my code is using grpc-web-client. maybe my Envoy setup is not correct? (I am also taking this from existing examples)

@smnbbrv
Copy link
Owner

smnbbrv commented Jun 12, 2021

By client implementation I mean packages grpc-web or @improbable-eng/grpc-web . This project is just a middleware that is adapted for these libs with corresponding packages.

The connection itself is implemented by the client lib and issues there are very hard to debug. It is almost impossible to say what is particularly wrong in your implementation without seeing and debugging the whole project and infrastructure; and, as being said above, is not a subject of ngx-grpc.

If you however will be able to find the issue on this side, it should be fixed of course.

@smnbbrv
Copy link
Owner

smnbbrv commented Mar 1, 2022

As long as the issue is not active anymore I close it. Please feel free to reopen in case it can be reproduced

@smnbbrv smnbbrv closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants