Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceID #2

Closed
muvans opened this issue Jan 7, 2017 · 2 comments
Closed

ReferenceID #2

muvans opened this issue Jan 7, 2017 · 2 comments

Comments

@muvans
Copy link

muvans commented Jan 7, 2017

Why do you have to use numeric here even when any string works? Is it a limitation on Safaricom end? After commenting out this check, my call still works!

public function usingReferenceId($referenceId)
{
    if (!is_numeric($referenceId)) {
        throw new \InvalidArgumentException('The reference id must be numeric');
    }
    $this->referenceId = $referenceId;
    return $this;
}
@SmoDav
Copy link
Owner

SmoDav commented Jan 10, 2017

Hi,
Thanks for the update. The reference ID was set to be numeric by Safaricom but was updated to allow strings. Forgot to update it but now it's all good.

@SmoDav SmoDav closed this as completed Jan 10, 2017
@muvans
Copy link
Author

muvans commented Jan 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants