Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we disable the default signal handler when we register it? #3

Closed
notgull opened this issue Feb 8, 2023 · 1 comment
Closed

Comments

@notgull
Copy link
Member

notgull commented Feb 8, 2023

Right now, when a signal is registered via the Signals type, the default signal handler is disabled. This requires the user to manually call the low-level signal handler. This is probably what's desired for most cases, like handling SIGINT, since the default signal handler for SIGINT ends the application. However, for other signals, it may be desired to call the default signal handler. I think there should be an option in add_signals or other to call the default signal handler on receipt.

@notgull
Copy link
Member Author

notgull commented Apr 25, 2023

Actually, this might be the only real way of doing it.

@notgull notgull closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant