Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for ARP retry during egress #368

Merged
merged 2 commits into from Aug 11, 2020

Conversation

thalesfragoso
Copy link
Contributor

The stack would send an ARP and put the Neighbor into the waiting state if it couldn't find a valid (non expired) hardware address, but it wouldn't allow for retries, stalling the socket indefinitely if we didn't get a response. These changes allow for retries after a silent timer has expired.

Closes #319

CC @birkenfeld

Copy link
Contributor

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a small suggestion to improve clarity of the log message

src/socket/meta.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ARP requests not coming through UDP "flood"
2 participants