Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issues using it in a designer #1

Closed
jogibear9988 opened this issue Nov 29, 2023 · 4 comments
Closed

Small issues using it in a designer #1

jogibear9988 opened this issue Nov 29, 2023 · 4 comments

Comments

@jogibear9988
Copy link
Contributor

Hey I tried your NPM in my designer, and it worked. (https://node-projects.github.io/web-component-designer-demo/index.html)
But I've a few comments/additions,...

  • How about adding the css with the ":host" selector, directly into the comontent? So the component has the css-properties defined, but the could be overriden when defined outside. So somone can see them directly in my designer (or also in the dev tools)
  • the attributes section in the custom-elements.json is missing the link to the property, so my designer could not set the attributes. like here: https://github.com/node-projects/chart-js-webcomponent/blob/1277d1a3cc802c3cc0a755f27e97d1a36b42b135/custom-elements.json#L62
  • You could use a AdoptedStylesheet, so you do not need a "style" tag in the dom, wich needs to be reparsed on each clone of the template.
@jogibear9988 jogibear9988 changed the title Small issues using it in designer Small issues using it in a designer Nov 29, 2023
@jogibear9988
Copy link
Contributor Author

One more issue: the custom-elements.json is missing in the npm package

@smontanus
Copy link
Owner

Resolved in your patch-1, patch-2, and patch-3 branches, along with a small syntax error fix from me. All branches merged and included in version 0.1.4. Thanks for the help!

@jogibear9988
Copy link
Contributor Author

I had one more typo in the package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants