Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix IDs to make them unique #210

Closed
theKashey opened this issue Oct 18, 2018 · 3 comments
Closed

Prefix IDs to make them unique #210

theKashey opened this issue Oct 18, 2018 · 3 comments

Comments

@theKashey
Copy link

🚀 Feature Proposal

Some features, like filters or complex styles requires id to be used. Unfortunately default dehavior of SVGO is no compress used id or className.
This leads to hell - every first id in every new SVG transformed would be named... "a".

Solution is simple - activate not-quite-public SVGO plugin - prefixId - svg/svgo#700.
Job is done.

Motivation

We had some issues with style collision in the past. And knew how easily it could be solved.

Example

Just believe me :)

Pitch

React is about componetization and isolation. This is must have feature.

@oriSomething
Copy link

Related work around svg/svgo#674 (comment)
But I 👍 for this feature built in

@gregberge gregberge added the v4 label Nov 4, 2018
gregberge added a commit that referenced this issue Nov 4, 2018
@theKashey
Copy link
Author

Something is very wrong here. I am getting prefix__a, and that is not UNIQUE!

@gregberge
Copy link
Owner

@theKashey please submit a new bug issue if there is a problem with this feature.

Repository owner locked as resolved and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants