Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-render graphs? #9

Closed
smsearcy opened this issue Oct 18, 2021 · 1 comment
Closed

Pre-render graphs? #9

smsearcy opened this issue Oct 18, 2021 · 1 comment

Comments

@smsearcy
Copy link
Owner

Since right now all the graphs have fixed periods, does it make more sense to pre-render the graphs after collecting the data?

Pros:

  • Lessens burden on Waitress to render (no more "waiting threads")
  • Rendering to file gets around the thread safe issues with graphv()

Cons:

  • Space concerns
  • Time to render graphs we aren't going to use?
@smsearcy
Copy link
Owner Author

This issue is less of a need now, since Gunicorn's process based workers seem to be preventing the issues we were having.

Moreover, I don't really want to devote the disk space to caching graphs, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant