Turn warnings into $qpsmtpd->log() calls #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaredj
commented
Dec 17, 2014
jaredj
commented
- This makes it possible to emit warnings in plugins that will wind up in the test suite
- This provides a quicker convention for logging, in the event that the logs in question would not be out of place in test suite output
- This allows unexpected warnings to make their way to the logs (rather than /dev/null in most cases)
This can be convenient, especially when one wants to emit a warning that will show up when running the test suite but still be properly logged in production
msimerson
added a commit
that referenced
this pull request
Dec 18, 2014
Turn warnings into $qpsmtpd->log() calls
jaredj
added a commit
to jaredj/qpsmtpd
that referenced
this pull request
Jan 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.