Skip to content

Commit fcee6e4

Browse files
committed
Jitter RNG ES: remove setting full entropy
Reasons: - Jitter RNG 2.2.0 in older kernels cannot produce full entropy (as you rightfully pointed out, thanks!) - Jitter RNG 3.x can produce full entropy (and that was the consideration of the patch), but I should drop the lines nonetheless, because the now present automatic resampling of entropy in [1] allows the LRNG to achieve full entropy even of the ES does not provide full entropy. Therefore, there is no harm in removing it these days. Reported-by: Joshua Hill Signed-off-by: Stephan Mueller <smueller@chronox.de>
1 parent 9a0046e commit fcee6e4

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

lrng_es_jent.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -328,18 +328,6 @@ static int __init lrng_jent_initialize(void)
328328
lrng_jent_initialized = true;
329329
pr_debug("Jitter RNG working on current system\n");
330330

331-
/*
332-
* In FIPS mode, the Jitter RNG is defined to have full of entropy
333-
* unless a different value has been specified at the command line
334-
* (i.e. the user overrides the default), and the default value is
335-
* larger than zero (if it is zero, it is assumed that an RBG2(P) or
336-
* RBG2(NP) construction is attempted that intends to exclude the
337-
* Jitter RNG).
338-
*/
339-
if (fips_enabled && CONFIG_LRNG_JENT_ENTROPY_RATE > 0 &&
340-
jent_entropy == CONFIG_LRNG_JENT_ENTROPY_RATE)
341-
jent_entropy = LRNG_DRNG_SECURITY_STRENGTH_BITS;
342-
343331
if (jent_entropy)
344332
lrng_force_fully_seeded();
345333

0 commit comments

Comments
 (0)