Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uploading entries #7

Closed
1 task done
0x111 opened this issue Jun 16, 2020 · 2 comments
Closed
1 task done

Support uploading entries #7

0x111 opened this issue Jun 16, 2020 · 2 comments
Labels

Comments

@0x111
Copy link
Member

0x111 commented Jun 16, 2020

Uploading an entry should be possible with a command but also with the option to listen on the "onsave" event of a file that is currently opened and has a valid path to tour workspace.

Two flows here:
Uploading with a command
* Run upload command
* The extension identifies sys_id and table from path and sys_id.txt file
* Calls the sn-edit upload --table tablename --sys_id sys_id command which will upload the entry
* Display a notification about success/failure

One flow in this case

  • Upload on save
    • The extension identifies sys_id and table from path and sys_id.txt file
    • Calls the sn-edit upload --table tablename --sys_id sys_id command which will upload the entry
    • Display a notification about success/failure
@0x111 0x111 added the feature label Jun 16, 2020
@0x111
Copy link
Member Author

0x111 commented Jun 20, 2020

Bind upload command to onDidSaveTextDocument: Event, check if current file is in our workspace and then upload if it is, if it is not display an error message.

@0x111 0x111 changed the title Suppot uploading entries Support uploading entries Jun 21, 2020
@0x111
Copy link
Member Author

0x111 commented Jun 30, 2020

Uploading using a command can be easily replicated but it will not be supported for now.
We support uploading an entry on the file save event. This should be enough and if there is demand we will add this later.

@0x111 0x111 mentioned this issue Jun 30, 2020
3 tasks
@0x111 0x111 closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant