Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new exclude expressions in use rule statements #153

Merged
merged 6 commits into from
Nov 8, 2022

Conversation

johanneskoester
Copy link
Contributor

Introduced by snakemake/snakemake#1717

Copy link
Member

@mbhall88 mbhall88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanneskoester could you format that file with black before merging this?

@johanneskoester
Copy link
Contributor Author

Mhm, I did. Let me check.

@johanneskoester
Copy link
Contributor Author

Oh no, I did it via the github interface, sorry.

@johanneskoester
Copy link
Contributor Author

Mhm, I guess I somehow have destroyed the parsing for use rule statements...

@johanneskoester
Copy link
Contributor Author

If the issue is obvious for you, could you help? If not, I will try to debug it later.

@mbhall88
Copy link
Member

It's not immediately obvious to me sorry. I won't be able to look at this until sometime late next week either sorry.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #153 (e327eb8) into master (09ed5ee) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          11       11           
  Lines         974      974           
  Branches      217      217           
=======================================
  Hits          956      956           
  Misses         10       10           
  Partials        8        8           
Flag Coverage Δ
unittests 98.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
snakefmt/parser/syntax.py 99.05% <100.00%> (ø)

@johanneskoester johanneskoester merged commit 6b4c774 into master Nov 8, 2022
@johanneskoester johanneskoester deleted the feat/userule-exclude branch November 8, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants