Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pyproject.toml to use setuptools features #1725

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Jun 18, 2022

Description

This PR introduces a pyproject.toml file described by PEP 518, and uses PyPA's build to check building the package (sdist and wheel files).

In addition, lots from setup.py is removed or simplified:

  • E.g. first few lines are not needed for Python 3, which is UTF-8 by default and has a print function
  • Dunders __author__ etc are not normally used in this file
  • Remove setuptools check, since this is a build requirement specified in the correct place (pyproject.toml)
  • Remove Python version check, since this is done with setuptools' python_requires
  • Note that lots of the static metadata from setup.py can be moved to either setup.cfg or pyproject.toml, but not done in this PR

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johanneskoester
Copy link
Contributor

Thank you!

@johanneskoester johanneskoester changed the title feat: add pyproject.toml to use setuptools features chore: add pyproject.toml to use setuptools features Jun 20, 2022
@johanneskoester johanneskoester merged commit 454bfd1 into snakemake:main Jun 22, 2022
@mwtoews mwtoews deleted the pyproject-toml branch June 22, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants