fix: remove superfluous comma causing TypeError in conda-frontend error message #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And yes, micromamba support would be nice! Any PRs welcome! |
mobilegenome
force-pushed
the
fix-frontend-msg-typeerror
branch
from
d8e8cbd
to
2378089
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running snakemake with micromamba a
CreateCondaEnvironmentExceptionshould be raised (should it really? that is a different story... ;)However, the code `msg += ("lorem ipsum",) tries to concatenate a str and tuple and causes a TypeError.
Removing the trailing comma fixes this issue and the error message is successfully created and raised.
QC
I don't think these are relevant for this simple fix.
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).