Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong rule names when nesting module imports #1817

Merged
merged 8 commits into from Aug 5, 2023

Conversation

kpj
Copy link
Contributor

@kpj kpj commented Aug 18, 2022

Description

Fix wrong rule names when nesting module imports.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@kpj kpj changed the title Fix wrong rule names when nesting module imports fix: fix wrong rule names when nesting module imports Aug 18, 2022
@kpj kpj changed the title fix: fix wrong rule names when nesting module imports fix: wrong rule names when nesting module imports Aug 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johanneskoester johanneskoester enabled auto-merge (squash) August 4, 2023 13:30
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 65c79a4 into snakemake:main Aug 5, 2023
7 checks passed
johanneskoester pushed a commit that referenced this pull request Aug 5, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.32.1](v7.32.0...v7.32.1)
(2023-08-05)


### Bug Fixes

* add missing spaces between lines that get concatenated.
([#2268](#2268))
([7238458](7238458))
* better message about profile usage upon execution
([#2391](#2391))
([cf8aea5](cf8aea5))
* do not overwrite default resources setting in azure batch executor
([#2395](#2395))
([4aef3b9](4aef3b9))
* updating of non-dict config values gives error
([#2364](#2364))
([b33aeec](b33aeec))
* wrong rule names when nesting module imports
([#1817](#1817))
([65c79a4](65c79a4))


### Documentation

* basics.rst: suggest VS Code instead of deprecated Atom as IDE
([#2368](#2368))
([1357316](1357316))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants