New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong rule names when nesting module imports #1817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpj
changed the title
Fix wrong rule names when nesting module imports
fix: fix wrong rule names when nesting module imports
Aug 18, 2022
kpj
changed the title
fix: fix wrong rule names when nesting module imports
fix: wrong rule names when nesting module imports
Aug 18, 2022
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
johanneskoester
approved these changes
Aug 5, 2023
johanneskoester
pushed a commit
that referenced
this pull request
Aug 5, 2023
🤖 I have created a release *beep* *boop* --- ## [7.32.1](v7.32.0...v7.32.1) (2023-08-05) ### Bug Fixes * add missing spaces between lines that get concatenated. ([#2268](#2268)) ([7238458](7238458)) * better message about profile usage upon execution ([#2391](#2391)) ([cf8aea5](cf8aea5)) * do not overwrite default resources setting in azure batch executor ([#2395](#2395)) ([4aef3b9](4aef3b9)) * updating of non-dict config values gives error ([#2364](#2364)) ([b33aeec](b33aeec)) * wrong rule names when nesting module imports ([#1817](#1817)) ([65c79a4](65c79a4)) ### Documentation * basics.rst: suggest VS Code instead of deprecated Atom as IDE ([#2368](#2368)) ([1357316](1357316)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix wrong rule names when nesting module imports.
QC
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).