fix: do not allow setting benchmark and between-workflow caching for the same rule. The reason is that when the result is taken from cache, there is no way to fill the benchmark file with any reasonable values. #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same rule. The reason is that when the result is taken from cache, there is no way to fill the benchmark file with any reasonable values.
johanneskoester
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
pushed a commit
that referenced
this pull request
Jul 21, 2023
🤖 I have created a release *beep* *boop* --- ## [7.30.2](v7.30.1...v7.30.2) (2023-07-20) ### Bug Fixes * do not allow setting benchmark and between-workflow caching for the same rule. The reason is that when the result is taken from cache, there is no way to fill the benchmark file with any reasonable values. ([#2335](#2335)) ([e2d64fa](e2d64fa)) * ensure lazy evaluation of resource functions/callables (this also entails, for now, a removal of the thread statistics in the yellow job stats table); further, added some clarifying sentences about resource function evaluation to the docs ([#2356](#2356)) ([4c591b7](4c591b7)) * handle non-PEP440 versions of apptainer/singulariy ([#2337](#2337)) ([dea6ba8](dea6ba8)) * remote GS builds too many inventories; io:collect_mtime always uses uncached mtime ([#2266](#2266)) ([bad9115](bad9115)) * Solve apptainer version issue ([#2333](#2333)) ([a876e0f](a876e0f)) * SyntaxWarnings due to non-raw regex pattern strings ([#2359](#2359)) ([a08c0b0](a08c0b0)) ### Documentation * clarify minimum Snakemake version for profiles ([86dc277](86dc277)) * clarify the channel priority in environment definition deployment.rst ([#2352](#2352)) ([76aa964](76aa964)) * fix typo (stackoverflow issue) ([#2365](#2365)) ([f770984](f770984)) * note on using checkpoint mechanism only for input function, not for params or resources. ([#2353](#2353)) ([4be2f9d](4be2f9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).