docs: update CHANGELOG.md: add minimum Python version bump #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dlaehnemann
changed the title
johanneskoester
added a commit
that referenced
this pull request
Aug 2, 2023
…ssary) (#2372) ### Description The respective bug was introduced with PR #2341, so it exists starting with version `7.30.2`. Also see issue #2369 and PR #2370 for further context. This code from PR #2341 seems to get run every time a conda environment is used: https://github.com/snakemake/snakemake/blob/13b5d4d11d7475f942531c51b6013962a88a72b7/snakemake/__init__.py#L8-L9 Thus, any conda environment in a rule with an older python version included, will trigger a: ``` File "/opt/conda/envs/snakemake/lib/python3.11/site-packages/snakemake/__init__.py", line 9, in <module> raise ValueError("Snakemake requires at least Python 3.9.") ValueError: Snakemake requires at least Python 3.9. ``` This would preclude snakemake from running any software that needs an older python version, so this is clearly an unwanted side-effect. But I am not sure how to fix this. Currently, this PR is only a minimal example test to trigger this behaviour in the CI tests. Hopefully, this will make debugging it quicker for @johanneskoester (or someone else?). ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake). --------- Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de> Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
|
That version bump was my mistake. I forgot about the implications for scripts. I changed the implementation so that it is not necessary anymore. The next release will be python 3.7 again, with a corresponding note in the changelog. |
|
Nevertheless, it does not hurt to have this glitch recorded in the changelog. |
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
pushed a commit
that referenced
this pull request
Aug 2, 2023
🤖 I have created a release *beep* *boop* --- ## [7.31.1](v7.31.0...v7.31.1) (2023-08-02) ### Bug Fixes * require python >=3.7 again (the python 3.9 dependency was unnecessary) ([#2372](#2372)) ([0d0e9c4](0d0e9c4)) ### Documentation * update CHANGELOG.md: add minimum Python version bump ([#2370](#2370)) ([48e934d](48e934d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2369
Add changelog entry for Python version bump
See #2341 (comment)