New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: require python >=3.7 again (the python 3.9 dependency was unnecessary) #2372
fix: require python >=3.7 again (the python 3.9 dependency was unnecessary) #2372
Conversation
Please format your code with black: |
A quick workaround for anybody getting this bug, until it is fixed: Downgrade your |
So, this bug gets triggered in the Windows CI already, right here is the actual error message: Currently rerunning the Linux CI, as this failed on slurm cluster creation earlier in the tests. |
The Linux CI failure seem to be an unrelated and obscure error, where the general GitHub Actions runner is |
Here's a related PR for the Linux CI failure with the slurm setup #2377 . |
I expect this to be fixed with the changes in #2305. However, that will become Snakemake 8.0. I'll think about a fix for the 7.x series, in order to have a final release that works. |
…m:snakemake/snakemake into fix-minimum-python-version-for-conda-envs
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
python >=3.9
requirement in rule conda envs🤖 I have created a release *beep* *boop* --- ## [7.31.1](v7.31.0...v7.31.1) (2023-08-02) ### Bug Fixes * require python >=3.7 again (the python 3.9 dependency was unnecessary) ([#2372](#2372)) ([0d0e9c4](0d0e9c4)) ### Documentation * update CHANGELOG.md: add minimum Python version bump ([#2370](#2370)) ([48e934d](48e934d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
The respective bug was introduced with PR #2341, so it exists starting with version
7.30.2
. Also see issue #2369 and PR #2370 for further context.This code from PR #2341 seems to get run every time a conda environment is used:
snakemake/snakemake/__init__.py
Lines 8 to 9 in 13b5d4d
Thus, any conda environment in a rule with an older python version included, will trigger a:
This would preclude snakemake from running any software that needs an older python version, so this is clearly an unwanted side-effect. But I am not sure how to fix this.
Currently, this PR is only a minimal example test to trigger this behaviour in the CI tests. Hopefully, this will make debugging it quicker for @johanneskoester (or someone else?).
QC
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).