fix: correctly report lineno #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
johanneskoester
changed the base branch from
main
to
testcase-syntaxerror-lineno
|
|
Thanks a lot! I have added a testcase from PR #2583 |
johanneskoester
merged commit 967a0d7
into
snakemake:testcase-syntaxerror-lineno
34 checks passed
|
The branch testcase-syntaxerror-lineno has been merged into main now, containing this PR and PR #2583. |
johanneskoester
pushed a commit
that referenced
this pull request
Jan 8, 2024
🤖 I have created a release *beep* *boop* --- ## [8.1.0](v8.0.1...v8.1.0) (2024-01-08) ### Features * add --sdm short opt for --deployment ([#2551](#2551)) ([fd8b4b0](fd8b4b0)) ### Bug Fixes * add mamba to docker image ([eb0c884](eb0c884)) * correctly report lineno ([#2584](#2584)) ([967a0d7](967a0d7)) * move apptainer into separate env in docker image ([94e9e2c](94e9e2c)) * single line f-string format error in py3.12 ([#2588](#2588)) ([87c06c0](87c06c0)) ### Documentation * add note on google executor backends ([ff8683c](ff8683c)) * diff 7 and 8 ([#2561](#2561)) ([ba22e07](ba22e07)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #2583, #1256 and #2574
QC
maybe #2583
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).