fix: Don't attempt to parse TBDString resources #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrightsman
changed the title
twrightsman
force-pushed
the
fix-dry-run-resources
branch
from
a3f030d
to
3b7a367
Compare
twrightsman
force-pushed
the
fix-dry-run-resources
branch
from
3b7a367
to
d4609ad
Compare
johanneskoester
approved these changes
Feb 15, 2024
|
Thank you! |
|
johanneskoester
pushed a commit
that referenced
this pull request
Feb 18, 2024
🤖 I have created a release *beep* *boop* --- ## [8.4.9](v8.4.8...v8.4.9) (2024-02-15) ### Bug Fixes * binary mem ([#2695](#2695)) ([18689b4](18689b4)) * Don't attempt to parse TBDString resources ([#2690](#2690)) ([f884b50](f884b50)) ### Documentation * added Mastodon follow label with just 'Follow' similar to X ([#2692](#2692)) ([7e36496](7e36496)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the
WorkflowErrors that occur when the resource parsing code tries to parseTBDStrings during a dry run.This should fix #2575 and fix #2555.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).