You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another try at #2176, where we try to gather more information about a job; for example, not only resources used, but also resources requested and size of input files.
Here, the original benchmark file is left as is, but there is an option to request an extended benchmark file if the extension is .jsonl.
The PR contains a test case for the changes or the changes are already covered by an existing test case.
The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
Is this a replacement of my PR? Sorry I haven't looked much into it. Just want to know if I still need to refactor my PR to the new format (I should have some more time to work on it in the next two weeks)
Not sure... I started it just to explore a simpler way to do it (just adding more info to the benchmark file), but I don't know if this is the best way to go (hence all the questions).
PS - that is also why I haven't added the docs and tests yet; will only do it if it is the right way to go.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fgvieira
force-pushed
the
extra_benchmark
branch
from
Description
Another try at #2176, where we try to gather more information about a job; for example, not only resources used, but also resources requested and size of input files.
Here, the original
benchmarkfile is left as is, but there is an option to request an extendedbenchmarkfile if the extension is.jsonl.Is there any other relevant info to include?
@SichongP @corneliusroemer feel free to comment.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).