fix: proper interpretation of standard resources given as strings (e.g. runtime as '5m'). Avoid the need to set additional quotes around size or timespan resources. Improved error messages for resource handling. #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test with 'runtime: "5m"' in human readable format. Ought to be parsable. Will - hopefully - break right now.
|
Breaks as expected. |
…akemake into fix/worflow-profile-parsing
johanneskoester
changed the title
|
johanneskoester
pushed a commit
that referenced
this pull request
Feb 24, 2024
🤖 I have created a release *beep* *boop* --- ## [8.5.0](v8.4.12...v8.5.0) (2024-02-24) ### Features * add ability to return input functions from input functions. Such nesting is evaluated 10 times at most. Beyond that, an error is thrown. ([#2717](#2717)) ([7a47924](7a47924)) * support for report plugins ([#2700](#2700)) ([2f7d4b5](2f7d4b5)) ### Bug Fixes * fix wait for files in case of using remote storage and remote execution ([#2718](#2718)) ([eec3a5f](eec3a5f)) * proper interpretation of standard resources given as strings (e.g. runtime as '5m'). Avoid the need to set additional quotes around size or timespan resources. Improved error messages for resource handling. ([#2716](#2716)) ([b6636e9](b6636e9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eventually, human-readable resource parsing for runtimes from workflow-profiles ought to be enabled.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).