Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand error on modules with prefix (#1614) #2803

Merged
merged 14 commits into from Apr 12, 2024

Conversation

fgvieira
Copy link
Contributor

@fgvieira fgvieira commented Apr 11, 2024

Description

Fix for #1614

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@fgvieira fgvieira marked this pull request as draft April 11, 2024 13:07
@fgvieira fgvieira changed the title fix: error on modules with prefix when expanding fix: expand error on modules with prefix (#1614) Apr 11, 2024
@fgvieira fgvieira marked this pull request as ready for review April 11, 2024 13:58
snakemake/io.py Outdated Show resolved Hide resolved
fgvieira and others added 2 commits April 12, 2024 12:30
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit c6bfcd7 into snakemake:main Apr 12, 2024
35 checks passed
johanneskoester pushed a commit that referenced this pull request Apr 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.10.7](v8.10.6...v8.10.7)
(2024-04-12)


### Bug Fixes

* expand error on modules with prefix
([#1614](#1614))
([#2803](#2803))
([c6bfcd7](c6bfcd7))
* failure message in cleanup_metadata
([#2800](#2800))
([4c7fe55](4c7fe55))
* handle async method in cleanup_storage_objects
([#2806](#2806))
([272205b](272205b))


### Documentation

* add Morten Lund as another maintainer.
([293bc05](293bc05))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@fgvieira fgvieira deleted the test_modules_prefix_expand branch April 12, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants