-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to mark files where path should not be modified #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneskoester
approved these changes
Jun 5, 2024
johanneskoester
requested changes
Jun 5, 2024
johanneskoester
requested changes
Jun 5, 2024
|
johanneskoester
approved these changes
Jun 7, 2024
johanneskoester
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [8.14.0](v8.13.0...v8.14.0) (2024-06-11) ### Features * add flag to mark files where path should not be modified ([#2888](#2888)) ([d142b46](d142b46)) * support per rule shell exec setting via resources ([#2862](#2862)) ([ab8d2dd](ab8d2dd)) ### Documentation * update FAQ - recommend ensure function for failing on empty output ([#2910](#2910)) ([b035071](b035071)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using modules with a prefix, the prefix is added to all input and output files. If an input file is defined in the config, the path becomes invalid. As such it is necessary to mark these files so that their path are not changed.
Not sure if
path_modified
is the best name.... maybeprotect_path
, ornot_modify_path
, orno_prefix
, orfixed_path
?QC
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).