Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to mark files where path should not be modified #2888

Merged
merged 12 commits into from
Jun 7, 2024

Conversation

fgvieira
Copy link
Contributor

@fgvieira fgvieira commented May 21, 2024

When using modules with a prefix, the prefix is added to all input and output files. If an input file is defined in the config, the path becomes invalid. As such it is necessary to mark these files so that their path are not changed.

Not sure if path_modified is the best name.... maybe protect_path, or not_modify_path, or no_prefix, or fixed_path?

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@fgvieira fgvieira changed the title feat: add flag to mark files whose path should not be modified feat: add flag to mark files where path should not be modified May 22, 2024
@fgvieira fgvieira requested a review from dlaehnemann May 23, 2024 08:19
@fgvieira fgvieira enabled auto-merge (squash) June 5, 2024 11:31
@fgvieira fgvieira disabled auto-merge June 5, 2024 11:31
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit d142b46 into snakemake:main Jun 7, 2024
35 checks passed
@fgvieira fgvieira deleted the no_path_modified branch June 8, 2024 15:45
johanneskoester pushed a commit that referenced this pull request Jun 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.14.0](v8.13.0...v8.14.0)
(2024-06-11)


### Features

* add flag to mark files where path should not be modified
([#2888](#2888))
([d142b46](d142b46))
* support per rule shell exec setting via resources
([#2862](#2862))
([ab8d2dd](ab8d2dd))


### Documentation

* update FAQ - recommend ensure function for failing on empty output
([#2910](#2910))
([b035071](b035071))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants