You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the emb_generate.py file, for every index, the program checks whether it is in the existing list of indices here
if idx in exisiting_indices:
continue
This operation is O(n) where n is the length of existing indices, this can be easily avoided by converting this list into a set before starting the loop. This is a minor change, hopefully the authors can take care of this in the next commit.
exisiting_indices = set(exisiting_indices)
The text was updated successfully, but these errors were encountered:
In the emb_generate.py file, for every index, the program checks whether it is in the existing list of indices here
This operation is O(n) where n is the length of existing indices, this can be easily avoided by converting this list into a set before starting the loop. This is a minor change, hopefully the authors can take care of this in the next commit.
The text was updated successfully, but these errors were encountered: