Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console-conf: update commit for LP: #1978339 #51

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

dbungert
Copy link
Contributor

Not moving this to a tag yet, as this fix is console-conf specific.
Picks up canonical/subiquity#1310

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Tests fail because your user has no permissions for that, but that's fine. I'll check if there is some way to run them before approving.

@alfonsosanchezbeato
Copy link
Member

@dbungert would you mind rebasing the PR? Due to snapcraft 7 being released you need some changes that we just merged in main.

Copy link
Member

@Meulengracht Meulengracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checks have passed now

@valentindavid valentindavid merged commit 7d46357 into canonical:main Jun 16, 2022
@dbungert dbungert deleted the lp-1978339 branch November 10, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants