snap/quotas: followups from previous PR #10198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2021
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Thanks to Pawel for spotting this optimization. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
…ferences This ensures we have consistent error messages here when providing multiple groups and reduces spurious unit test failures in a followup where we provide multiple invalid groups that fail validation as we return on the first invalid group found. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
This eliminates the chance we encounter cycles in the sub-groups and infinitely recurse. We also test for this specifically to ensure that the cycle detection logic actually works. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
feature/quota-groups-2
branch
from
048e0fd
to
26c4d53
Compare
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
4 tasks
pedronis
reviewed
Apr 28, 2021
|
@anonymouse64 I think https://github.com/snapcore/snapd/pull/10152/files#r621290802 still needs fixing? |
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
This is because we want to return multi-errors here eventually instead, in which case it doesn't matter if we iterate over the groups in non-deterministic order since we will always get the same set of errors back if there are multiple errors in the set of groups provided. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Thanks to Pawel for spotting this one Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
stolowski
reviewed
Apr 28, 2021
stolowski
reviewed
Apr 28, 2021
stolowski
reviewed
Apr 28, 2021
stolowski
reviewed
Apr 28, 2021
pedronis
approved these changes
Apr 28, 2021
…g lists Also change the comments to make clear we are being paranoid about cycle detection before recursing deeper into the tree. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
pedronis
reviewed
Apr 28, 2021
Thanks to Samuele for the suggestion Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses comments from #10152.