o/servicestate: test has internal ordering issues, consider both cases #10206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties any of the two groups can end up being checked first and produce the error seen maybe the underlying function should use a multi-error but as we mantain the state there it might be overkill
pedronis
added
⚠ Critical
|
This bug is also fixed already in #10198 which ensures that we loop over all groups deterministically |
I considered that, but it feels a bit overkill to me, if we expect those errors to happen then a multi-error would be better instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any of the two groups can end up being checked first and produce the error seen
maybe the underlying function should use a multi-error but as we maintain the state there it might be overkill