Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snapstate,many: implement snap install --unaliased #3375
Conversation
Some checks were not successful
pedronis
added this to the 2.27 milestone
May 22, 2017
All checks have passed
codecov-io
commented
May 22, 2017
Codecov Report
@@ Coverage Diff @@
## master #3375 +/- ##
==========================================
+ Coverage 77.53% 77.54% +0.01%
==========================================
Files 367 367
Lines 25156 25167 +11
==========================================
+ Hits 19504 19516 +12
+ Misses 3904 3903 -1
Partials 1748 1748
Continue to review full report at Codecov.
|
stolowski
reviewed
May 23, 2017
The "--unaliased" name sounds a little weird to me. How about '--no-aliases'? Otherwise looks good.
chipaca
reviewed
May 23, 2017
Can you add a test that installs a snap with --unaliased and then refreshes?
Also, could you add Unaliased to TestEnableRunThrough?
| + if err != nil { | ||
| + return snapstate.Flags{}, err | ||
| + } | ||
| + if inst.Unaliased { |
|
Can you add a test that installs a snap with --unaliased and then refreshes? Also, could you add Unaliased to TestEnableRunThrough? |
niemeyer
approved these changes
May 23, 2017
Just a trivial suggestion, but LGTM with or without it.
| @@ -797,6 +798,17 @@ func (inst *snapInstruction) modeFlags() (snapstate.Flags, error) { | ||
| return modeFlags(inst.DevMode, inst.JailMode, inst.Classic) | ||
| } | ||
| +func (inst *snapInstruction) installFlags() (snapstate.Flags, error) { |
niemeyer
May 23, 2017
Contributor
Do we need a separate method for this? Feels like it might be in modeFlags itself.
pedronis
added some commits
May 23, 2017
pedronis commentedMay 22, 2017
No description provided.