snapstate,many: implement snap install --unaliased #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3375 +/- ##
==========================================
+ Coverage 77.53% 77.54% +0.01%
==========================================
Files 367 367
Lines 25156 25167 +11
==========================================
+ Hits 19504 19516 +12
+ Misses 3904 3903 -1
Partials 1748 1748
Continue to review full report at Codecov.
|
stolowski
reviewed
May 23, 2017
chipaca
reviewed
May 23, 2017
| if err != nil { | ||
| return snapstate.Flags{}, err | ||
| } | ||
| if inst.Unaliased { |
There was a problem hiding this comment.
is this better, or worse than flags.Unaliased = inst.Unaliased?
|
Can you add a test that installs a snap with --unaliased and then refreshes? Also, could you add Unaliased to TestEnableRunThrough? |
niemeyer
approved these changes
May 23, 2017
| @@ -797,6 +798,17 @@ func (inst *snapInstruction) modeFlags() (snapstate.Flags, error) { | |||
| return modeFlags(inst.DevMode, inst.JailMode, inst.Classic) | |||
| } | |||
|
|
|||
| func (inst *snapInstruction) installFlags() (snapstate.Flags, error) { | |||
There was a problem hiding this comment.
Do we need a separate method for this? Feels like it might be in modeFlags itself.
chipaca
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.