tests: remove mount_id and parent_id from mount-ns test data #7448
Conversation
|
This branch includes #7446 which is opened for separate review. |
zyga
force-pushed
the
tweak/no-mount-ids-ns-test
branch
from
7e1ac4a
to
e93e4b8
Compare
|
In general, I think this change would be really helpful in looking at the diff between different mount tables, however the one potential concern I have is that if a mount was unmounted then remounted, then IIUC the Overall +1 on this idea though - I like 1-line diffs 😃 |
|
The problem of not detecting things being unmounted and then mounted back again is valid but not applicable to this specific test. The test only measures static properties. The regression test in #7436 handles some of the dynamic properties. In addition as you observed the renumbering does make the Thank you for the +1. I will work towards making this pull request mergeable. |
The mount-ns test is useful as it shows a realistic view of the mount table. The mount IDs are re-numbered and are pretty much just a sequence. While some work went into making it easy to understand which mount namespace we are looking at, by checking the mount identifier value for membership in ranges 0..999, 1000..1999 or 2000..2999 - the overall value comes at a great cost. Any insertions or removals cause massive re-numbering to occur below the change. This makes it difficult to evaluate differences that a patch is introducing without manually convincing oneself of the "real" diff buried inside the diff printed by the tooling. This patch discards the first fro columns, namely mount_id and parent_id in the hope that the resulting output is clearer and more useful. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
zyga
force-pushed
the
tweak/no-mount-ids-ns-test
branch
from
e93e4b8
to
40da1fc
Compare
|
Dear reviewers, this patch really comprises of a one-line addition and two-column removal https://github.com/snapcore/snapd/pull/7448/files#diff-36e872aea1fc7dba34c7dfa820f13ac0R108 |
|
Merging with +1 in a comment from @anonymouse64 above. |
The mount-ns test is useful as it shows a realistic view of the mount
table. The mount IDs are re-numbered and are pretty much just a
sequence. While some work went into making it easy to understand which
mount namespace we are looking at, by checking the mount identifier
value for membership in ranges 0..999, 1000..1999 or 2000..2999 - the
overall value comes at a great cost. Any insertions or removals cause
massive re-numbering to occur below the change. This makes it difficult
to evaluate differences that a patch is introducing without manually
convincing oneself of the "real" diff buried inside the diff printed by
the tooling.
This patch discards the first two columns, namely mount_id and parent_id
in the hope that the resulting output is clearer and more useful.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl