-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usersession/userd: add zoommtg url support #8304
usersession/userd: add zoommtg url support #8304
Conversation
Original-Author: troyready <troy@troyready.com> Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
471303b
to
7f678b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov Report
@@ Coverage Diff @@
## master #8304 +/- ##
========================================
Coverage 80.65% 80.65%
========================================
Files 717 724 +7
Lines 57254 57632 +378
========================================
+ Hits 46177 46484 +307
- Misses 7481 7513 +32
- Partials 3596 3635 +39
Continue to review full report at Codecov.
|
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
What's the status here, do we need jamie or can this go in as is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked in #8254 (comment) about the contents of the URL, but didn't get back anything definitive, so I looked and found: https://medium.com/zoom-developer-blog/zoom-url-schemes-748b95fd9205. The contents of the URL scheme are fine and this PR can be applied as is.
That said, should we also include "zoomus"? Based on the above blog, it seems 'no', but I'm not familiar with zoom URL schemes so I'm not sure. That shouldn't block this PR since if it comes up we can add it later.
This seemed blocked on me so since I provided my review, I removed the blocked tag. |
@jdstrand let's say no until someone asks us for it. I haven't seen it in the wild either |
…ted-scheme usersession/userd: add zoommtg url support Signed-off-by: Ian Johnson <person.uwsome@gmail.com>
Why is this the only custom url scheme allowed through, while there are many many other custom url schemes that are still being blocked? |
@nermolov there's a broad fix in a testing release now that should finally address the core URL problem (instead of the previous strategy of whitelisting them). (I hesitated to comment here on a closed PR & pollute it with comment spam, but since this is a particularly important issue I think it's relevant to cross-post) |
Originally committed by @troyready in #8254