tests/main/cohorts: replace yq with a Python snippet #9807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yq tool changed its command line arguments and the test broke. Try not to depend on external tools and use a simple Python snippet to extract the cohort key. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
So that we don't have to deal with silly quoting when calling test-snapd-sh.sh. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
bboozzoo
added
⚠ Critical
jhenstridge
reviewed
Jan 4, 2021
| command="$1" | ||
| shift | ||
|
|
||
| exec "$command" "$@" |
There was a problem hiding this comment.
You could simplify the last three lines of this script to simply do exec "$@". No need to split off $1.
There was a problem hiding this comment.
Fair point. We carry a copy of this script in a couple of places. I can update them in a followup.
sergiocazzolato
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
yqtool changed its command line arguments and the test broke. Try not todepend on external tools and use a simple Python snippet to extract the cohort key.