This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Persistently store cookies per user for UPS #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusTomlinson
changed the title
|
LGTM |
MarcusTomlinson
changed the title
| @@ -49,6 +49,11 @@ ApplicationWindow { | |||
| id: webView | |||
| focus: true | |||
|
|
|||
| context: WebContext { | |||
| dataPath: Qt.application.arguments[1] | |||
There was a problem hiding this comment.
I find it a bit dangerous to hardcode this, ... we might decide at some point to change the command line args and this might fail silently (since it is not really part of the typical qmlscene args)?
There was a problem hiding this comment.
Good point. I've made the dataPath argument more explicit by expecting "--cookie_path=xxx"
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added a conditional to layout-banner.hbs to reenable the "Profile" icon but only for UPS. The image looks the best fit for the "My Snaps" option in UPS.