Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Use the offset from UTC heuristic to select the proper timezone in da… #200

Merged
merged 6 commits into from
Mar 15, 2017
Merged

Use the offset from UTC heuristic to select the proper timezone in da… #200

merged 6 commits into from
Mar 15, 2017

Conversation

AlexandreAbreu
Copy link
Contributor

…te time settings

@AlexandreAbreu AlexandreAbreu changed the title Use the offset from UTC heuristic to select the proper timezone in da… WIP Use the offset from UTC heuristic to select the proper timezone in da… Mar 14, 2017
@justincan
Copy link
Contributor

  • The change to be data driven is good and necessary
  • The other parts shouldn't happen; Because being in the same UTC offset does not imply being in the same timezone.

I vote we wait for OK to use react-timezone, or similar, and populate it with data collated by snapweb.

@AlexandreAbreu
Copy link
Contributor Author

I agree about your comment about the "being in the same UTC offset does not imply being in the same timezone" but the point of this is to offer a somewhat "reasonable" simplification (at least for the time being)... There is currently a gap in the code. And the fact that we cannot display a meaningful "timezone" string for basic North American locations (like me w/ Montreal or Toronto timezone strings) is really bad imo, ... I agree that it is not a final solution,

It is a tricky subject and from the UI perspective, ...

@dbarth
Copy link

dbarth commented Mar 15, 2017

I'd vote for landing, otherwise the vast majority of users live in "Samoa and Chrismas Island", which feels like a bug in most other parts of the world.

@dbarth
Copy link

dbarth commented Mar 15, 2017

Knowing that this gives us time to implement a better solution and review with Design.

@AlexandreAbreu AlexandreAbreu changed the title WIP Use the offset from UTC heuristic to select the proper timezone in da… Use the offset from UTC heuristic to select the proper timezone in da… Mar 15, 2017
@dbarth dbarth merged commit 6cda11c into canonical:master Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants