This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Use StoreSections from snapweb-toolkit. #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincan
force-pushed
the
snapweb-toolkit-2
branch
from
efc393c
to
796be3e
Compare
|
Could you make sure that the selenium tests work with those changes (along w/ the merge conflicts) ? |
justincan
force-pushed
the
snapweb-toolkit-2
branch
from
2d081e3
to
4428c40
Compare
|
Updated to master. Test failures appear unrelated to this branch. so shouldn't be in this commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for acceptance of the ConfirmationDialog component to snapweb-toolkit.
See canonical-web-and-design/snapweb-toolkit#4
Not to be committed until accepted.