Core20 and Java 17 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popey
reviewed
Oct 8, 2023
BGI trigger didn't seem to work - at least no updates to builds since 2021-04-16-11:05:25. This COULD be due to an old version of Java used by the previous snacraft.yaml.
Using same method to grab version from git. May not be ideal, but more consistent and less taxing on build servers. Also removed `unzip` from build-packages.
Clean up snapcraft yaml and change build procedures
Using same method to grab version from git. May not be ideal, but more consistent and less taxing on build servers. Also removed `unzip` from build-packages.
Build version settings
|
I've got a "final" rev for the yaml. Local build is running here on my end. |
|
@popey do you need anything further from me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also created a launcher script since the command wasn't working due to formatting.
Fixes #29
Fixes #32