Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add other input formatters #23

Open
hankbeasley opened this issue Jan 13, 2020 · 3 comments
Open

Cannot add other input formatters #23

hankbeasley opened this issue Jan 13, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@hankbeasley
Copy link

Need to check that the incoming content type is json and return false if it is not otherwise we cannot add input formatters for other types.

public bool CanRead(InputFormatterContext context)
        {
            return true;//should be false if not json.
        }
@GooRiOn GooRiOn added the good first issue Good for newcomers label Jan 14, 2020
@GooRiOn
Copy link
Member

GooRiOn commented Jan 14, 2020

Thanks for this issue, will look at this :)

@sarthakvijayvergiya
Copy link

Hi, @GooRiOn If anyone is not working on this may I pick this issue?
Do we have any contribution guidelines to contribute on this project?

@abuzaforfagun
Copy link

Hello @GooRiOn ,
Is this method used anywhere? I found no reference of this method.

Most probably this is a dead code. Better to remove that one.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants