Convey.WebApi / invocation of IRequestHandler

[b-y-t-e]

Hello,
I have a problem with an invocation of simple IRequestHandler. The handler will never get invoked.

public class Program
{
    public static async Task Main(string[] args)
    {
        await WebHost
            .CreateDefaultBuilder(args)
            .ConfigureServices(services => services
                .AddConvey()
                .AddWebApi()
                .Build())
            .Configure(app => app
                .UseEndpoints(endpoints => endpoints
                    .Get("", ctx => ctx.Response.WriteJsonAsync(ctx.RequestServices.GetService<AppOptions>() ) )
                    .Delete<DeleteParcel>("parcels/{parcelId}")))
            .UseLogging()
            .Build()
            .RunAsync();
    }
}
public class DeleteParcel : IRequest
{
    public int ParcelId { get; }
    public DeleteParcel(int parcelId)
    {
        ParcelId = parcelId;
    }
}
public class DeleteParcelHandler : IRequestHandler<DeleteParcel, int>
{
    public async Task<int> HandleAsync(DeleteParcel request)
    {
        return request.ParcelId;
    }
}

[PiotrFerenc]

change IRequest to ICommand and IRequestHandler to ICommandHandler

[b-y-t-e]

Thanks for response, but ICommand does not have any result type, which is crucial for me.

[PiotrFerenc]

https://github.com/devmentors/Pacco.Services.Customers/blob/master/src/Pacco.Services.Customers.Application/Commands/Handlers/ChangeCustomerStateHandler.cs#L31

https://github.com/devmentors/Pacco.Services.Customers/tree/master/src/Pacco.Services.Customers.Core/Exceptions

[PiotrFerenc]

    class CreateOrderHandler : ICommandHandler<CreateOrderCommand>
    {
        public Task HandleAsync(CreateOrderCommand command)
        {
          return Task.FromResult(command.Id);
        }
    }

[b-y-t-e]

Thanks for the answer! I know about ICommandHandler and ICommand interfaces (and I use them with no problem). However I would like to bend CQRS assumptions a little, and I would like that commands are able to return the value to the client. According to the documentation (https://convey-stack.github.io/documentation/Web-API/) IRequestHandler interface is ideal for this scenario, but the example from documentation does not work.

[Allann]

I understand the frustration, I recently swapped in MediatR (https://www.nuget.org/packages/MediatR/) with success, maybe if you are blocked this could be a solution?.

[GooRiOn]

Neither of the CQRS packages provide you such thing, however there's the IRequestHandler<,> type beeing provided by WebAPI package along with its internal registration:

https://github.com/snatch-dev/Convey/blob/5b9a36606bad36d071461d984413f3c4e5adeca6/src/Convey.WebApi/src/Convey.WebApi/Requests/IRequestHandler.cs

Convey/src/Convey.WebApi/src/Convey.WebApi/Extensions.cs

Line 109 in 3c6fe48

builder.Services.Scan(s =>