Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: flattenMapMarker behavior improvement #51

Closed
mlasevich opened this issue Jun 26, 2020 · 5 comments
Closed

feature request: flattenMapMarker behavior improvement #51

mlasevich opened this issue Jun 26, 2020 · 5 comments
Labels
help wanted

Comments

@mlasevich
Copy link
Contributor

mlasevich commented Jun 26, 2020 •
edited
Loading

it appears the flattenMapMarker option offers choice between two options - either ignore the marker id or mangle it - can we add a new option to actually use the marker name?

I.e. if i add marker with name "data" - use "data" as marker name instead of "marker.data"?
@mlasevich mlasevich changed the title feature requestflattenMapMarker behavuor improvement feature request: flattenMapMarker behavuor improvement Jun 26, 2020
@mlasevich mlasevich changed the title feature request: flattenMapMarker behavuor improvement feature request: flattenMapMarker behavior improvement Jun 26, 2020
@sndyuk
Copy link
Owner

sndyuk commented Oct 3, 2020

@mlasevich Sorry for the late reply. I think it's a good option. but I actually don't understand well so if you make p/r it will be helpful. Thanks!

@mlasevich
Copy link
Contributor Author

Let me look at it. TBH, its been a while and I am trying to recall what was going on for this...

@mlasevich mlasevich mentioned this issue Oct 12, 2020
Merged
@mlasevich
Copy link
Contributor Author

The PR is a bit larger, but short of it is that I made the prefix that is currently hardcoded be an option that can be set - including being set to a blank.

@sndyuk
Copy link
Owner

sndyuk commented Oct 24, 2020

It's been released on 1.8.3. Thanks!

@sndyuk sndyuk closed this as completed Oct 24, 2020
@mlasevich
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sndyuk @mlasevich