Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isotopes assigned to different pc groups #38

Open
shefalilathwal opened this issue Jul 11, 2019 · 4 comments
Open

Isotopes assigned to different pc groups #38

shefalilathwal opened this issue Jul 11, 2019 · 4 comments

Comments

@shefalilathwal
Copy link

I was testing the single sample example given in CAMERA and in the final results, found several isotope annotations that were separated into different pcgroup after the corr_eic_th is applied. I am using the following code from the example on bioconductor:
file <- system.file('mzdata/MM14.mzdata', package="CAMERA") xs <- xcmsSet(file,method="centWave",ppm=30,peakwidth=c(5,10)) an <- xsAnnotate(xs) anF <- groupFWHM(an, perfwhm = 0.6) anI <- findIsotopes (anF, mzabs = 0.01) peak_iso <- getPeaklist(anI) anIC <- groupCorr(anI, cor_eic_th = 0.75) peak_iso_cor <- getPeaklist(anIC)

The second peak list after applying eic correlation threshold (peak_iso_cor) separates several isotopes into different pc groups. A snapshot of the table shows the 13th and 7th isotope pairs belonging to different pcgroups.

Screen Shot 2019-07-11 at 12 11 39 PM

My understanding after reading the user documentation was that features annotated as isotopes will stay in the same pcgroup even if they don't meet the cor_eic_th criterion.

If the correlation value between two peaks is higher than the threshold cor_eic_th, it will stay in the group, otherwise both are separated. If the peaks are annotated isotope ions, they will not be divided.

Can you help me understand what might be going on here?
I am attaching the peaktable as well.
camera_example_isotope_corr.xlsx

@stanstrup
Copy link
Contributor

The default groupCorr parameters are:

calcIso = FALSE, calcCiS = TRUE, calcCaS = FALSE

Thus, the isotope information is never used in that step unless you enable it.

That said it never made sense to me to look for isotopes before groupCorr.

@shefalilathwal
Copy link
Author

@stanstrup I had tested with the isotope information set to TRUE as well and got the same result as reported above.
I do agree with you though that logically it doesn't make much sense to look for isotopes before groupCorr. Maybe this can be reflected in the user documentation.

@yguitton
Copy link

Hi @stanstrup, @sneumann

It's an old post, but I'm facing the same issue. Setting calcIso to true seems to have no effect (as if the step is not launched or is not efficient).
In my case the intensities of [13]C are quite low and may explain that groupCorr wants to exclude them from the original pcgroup due to low pearson correlations between EICs. But my understanding of the calcIso parameter was that it was created to avoid such splitting. Am I wrong?

Regards
Yann

image

@fgiacomoni
Copy link

Hi everybody
@sneumann, we are facing same issue in W4M with a new interactive tool.
Do you have few minutes to give your feedback on this issue/limit? Thank you very much
Do we start to imagine another strategy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants