Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heed of warning - avoid use #19

Open
davidzwa opened this issue Jul 27, 2020 · 0 comments
Open

Heed of warning - avoid use #19

davidzwa opened this issue Jul 27, 2020 · 0 comments

Comments

@davidzwa
Copy link

davidzwa commented Jul 27, 2020

Although I appreciate the existence of this package, there are multiple problems with it:

  • Barely maintained, and PR's changes are very breaking. This is a near-PRIMITIVE type, but the implementation is not consistent. This means people will have to change their whole project :S (as I have to do now)
  • Outputs any on toJSON() with a property:value structure. This is not how I would serialize, and it is quite a dealbreaker. I would serialize in a flat manner value directly, which is consistent with f.e. C#. Now I have to intercept the Guid and fix it.
  • People should implement the Guid Primitive themselves by looking at a gist, instead of relying on something which doesnt fit all. Having total control over the guid's serialization setting is a must.

Again, I really appreciate the package and the effort, but the fact that there are so many downloads made me very worried. This is one of the most used primitives on an API side (especially .NET Core).

I can PR something, but looking at the current amount of open PR's those should be processed first. I understand the backwards-compatible hold-up, but this is a limbo state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant