Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more characters in model name (and number) #82

Closed
peelman opened this issue Nov 27, 2013 · 2 comments
Closed

allow more characters in model name (and number) #82

peelman opened this issue Nov 27, 2013 · 2 comments

Comments

@peelman
Copy link

peelman commented Nov 27, 2013

I assume the restrictiveness is a side effect of #57. Not sure what the best solution is here. But right now, you can't even edit the seed data because the validation will fail (seed models include ( ) and ,).

If it were me, I would validate their presence and that's it, but I don't know what other concerns you already ran into that had you add the validators in the first place.

@snipe
Copy link
Owner

snipe commented Nov 28, 2013

The validators are there to reduce risk of XSS. Laravel does a nice job of escaping data on the way out, but I've run into a few jquery plugins in this project that reversed that escaping, actually re-assembling the HTML encoding and making it vulnerable. There's just no reason to use < or > in this data, so I'm validating against it. I'll find a better balance of characters to filter out - that custom validate was my first stab at writing a custom validator in this framework, so I expect to massage the particulars over time. In general, whitelisting is a better approach than blacklisting, IMHO. Takes longer, but more thorough.

@snipe
Copy link
Owner

snipe commented Nov 28, 2013

Fixed in 33f81ab

@snipe snipe closed this as completed Nov 28, 2013
This was referenced Jul 19, 2016
@ESWBitto ESWBitto mentioned this issue Mar 16, 2017
2 tasks
@Bjufen Bjufen mentioned this issue Feb 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants