Fix bug in Ngram splitting bug #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehsiao
changed the title
Rather than returning the TemporarySpan, along with its splits, Snorkel was returning the TemporarySpan twice, and only the 2nd split. Hiromu Hota fixed this bug in Fonduer in [1]. This commit fixes it for Snorkel. [1] HazyResearch/fonduer#108 Co-authored-by: Hiromu Hota <hiromu.hota@hal.hitachi.com>
lukehsiao
force-pushed
the
lukehsiao-patch-1
branch
from
aee81da
to
a06c782
Compare
A bug occurs if the text of the span ends in one of the split tokens. For example, "BC546-" will try to yield "BC546-", "BC546", and an empty span with invalid char_start and char_end. This stops it from yielding the empty span. See HazyResearch/fonduer#112. Co-authored-by: Hiromu Hota <hiromu.hota@hal.hitachi.com>
|
Thanks!! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HiromuHota fixed this bug in Fonduer in HazyResearch/fonduer#108 and HazyResearch/fonduer#112. This commit fixes it for Snorkel.