Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in Ngram splitting bug #1020

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Fix bug in Ngram splitting bug #1020

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a06c782
Fix bug in Ngram splitting logic
lukehsiao Aug 20, 2018
93f75fa
Fix bug of yielding empty spans
lukehsiao Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions snorkel/candidates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ def apply(self, context):
m = re.search(self.split_rgx, context.text[start-offsets[0]:end-offsets[0]+1])
if m is not None and l < self.n_max + 1:
ts1 = TemporarySpan(char_start=start, char_end=start + m.start(1) - 1, sentence=context)
if ts1 not in seen:
if ts1 not in seen and ts1.get_span():
seen.add(ts1)
yield ts
yield ts1
ts2 = TemporarySpan(char_start=start + m.end(1), char_end=end, sentence=context)
if ts2 not in seen:
if ts2 not in seen and ts1.get_span():
seen.add(ts2)
yield ts2

Expand Down