Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in Ngram splitting bug #1020

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Fix bug in Ngram splitting bug #1020

merged 2 commits into from
Aug 22, 2018

Commits on Aug 20, 2018

  1. Fix bug in Ngram splitting logic 

    Rather than returning the TemporarySpan, along with its splits, Snorkel
was returning the TemporarySpan twice, and only the 2nd split. Hiromu
Hota fixed this bug in Fonduer in [1]. This commit fixes it for Snorkel.

[1] HazyResearch/fonduer#108

Co-authored-by: Hiromu Hota <hiromu.hota@hal.hitachi.com>
    @lukehsiao
    lukehsiao and Hiromu Hota committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    a06c782 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Fix bug of yielding empty spans 

    A bug occurs if the text of the span ends in one of the split tokens.
For example, "BC546-" will try to yield "BC546-", "BC546", and an empty
span with invalid char_start and char_end. This stops it from yielding
the empty span.

See HazyResearch/fonduer#112.

Co-authored-by: Hiromu Hota <hiromu.hota@hal.hitachi.com>
    @lukehsiao
    lukehsiao and Hiromu Hota committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    93f75fa View commit details
    Browse the repository at this point in the history