Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser support question / Reflect usage #52

Closed
petetnt opened this issue Feb 21, 2018 · 2 comments
Closed

Browser support question / Reflect usage #52

petetnt opened this issue Feb 21, 2018 · 2 comments

Comments

@petetnt
Copy link

petetnt commented Feb 21, 2018

Hi! First of all: awesome library!

I was looking into a unrelated deepFreeze issue when I found js-flock, which recommended elsewhere. Turns out that IE11 doesn't support Reflect, which was first added in #37 which means that IE11 support is out of the question without polyfills.

Is the IE11 support out of the question in general / on purpose, or is there some other way to fix the issue in #37 without relying on Reflect?

Thanks a lot!

@snovakovic
Copy link
Owner

snovakovic commented Feb 28, 2018

@petetnt first of all sorry for late reply!

Actually truth is that it's very easy to fix #37 without relying on Reflect. I kind of regret decision of using Reflect for exact same reasons you described in issue.

I will push new version without reflect!

@snovakovic
Copy link
Owner

snovakovic commented Feb 28, 2018

@petetnt I have remove reflect usage from deepFreeze and publish new version. It's should work in IE11 from version 3.1.6. Disclaimer: I haven't actually tested it in IE11 as I don't have access to IE11 at this point.

I'll close the Issue and in case there is any other issue you can reopen it.

Just one more note by default js-flock is exporting unmodified ES6 code so when used in browser you should load transpiled version of code as described in documentation e.g const sort = require('js-flock/es5/deepFreeze'); or you can run it through your bable build process depending on your preferences. Let me know if you have any questions regarding that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants